Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardhat-core: upgrade chokidar to v4 #5746

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

talentlessguy
Copy link
Contributor

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

I bumped Chokidar to v4 from v3, which removed 11 dependencies and glob support, which Hardhat is not using. It still depends on mocha which depends on v3.5, so I will create a subsequent PR to bump it there

Copy link

changeset-bot bot commented Sep 13, 2024

🦋 Changeset detected

Latest commit: 12d1980

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hardhat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 10:22pm

Copy link
Member

@alcuadrado alcuadrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @talentlessguy! Great to see you here.

@alcuadrado alcuadrado merged commit d02efe9 into NomicFoundation:main Sep 13, 2024
108 checks passed
Copy link

gitpoap-bot bot commented Sep 13, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Hardhat Contributor:

GitPOAP: 2024 Hardhat Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@talentlessguy talentlessguy deleted the chokidar-v4 branch September 14, 2024 09:13
@schaable
Copy link
Member

Released in Hardhat v2.22.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants